IBX-7959: Create content permission regression with section limitation

[yvh]

Fix issue IBX-7959

Question	Answer
JIRA issue	IBX-7959
Type	bug
Target version	v4.6
BC breaks	no
Doc needed	no

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Asked for a review (ping @ibexa/engineering).

[webhdx]

Thanks for the contribution :)

[ViniTou]

Can we check if failing behat test is not related to change?
@barbaragr

[barbaragr]

Hi, behat tests are failing because of missing Section/View permission.
For editor user created just like it says here https://issues.ibexa.co/browse/IBX-7959 and here https://issues.ibexa.co/browse/IBX-7961 Create button is disabled, but applying changes from this PR results with 403 error: section/view permissions are missing for editor - user cannot enter Content structure, UDW is full of loading spinners. If I add section/view to the editor policies, Content structure works fine, but in UDW there are still some issues with access.

[glye]

I verified that this fix, after the last update, also fixes https://issues.ibexa.co/browse/IBX-7961
so I'll close that as a duplicate.

[ciastektk]

Hi! @yvh, could you please add these two changes to make your fix complete and allow us to proceed PR?

1. Add branch from PR IBX-7959: Added ContentInfo::getSectionId strict getter core#348 as a dev dependency of ibexa/core and in your fix use getSectionId method. We're moving away from using magic in codebase.
2. As @barbaragr mentioned, same error also occurs in UDW. In https://github.com/ibexa/admin-ui/blob/main/src/bundle/Controller/Permission/LanguageLimitationController.php#L47 we should also use $contentInfo->getSectionId();

Thank you in advance.

[ciastektk]

As described here: #1213 (comment)

[patrickallaert]

Hey @ciastektk,

Hi! @yvh, could you please add these two changes to make your fix complete and allow us to proceed PR?

1. Add branch from PR Added ContentInfo::getSectionId core#348 as a dev dependency of ibexa/core and in your fix use getSectionId method. We're moving away from using magic in codebase.
2. As @barbaragr mentioned, same error also occurs in UDW. In https://github.com/ibexa/admin-ui/blob/main/src/bundle/Controller/Permission/LanguageLimitationController.php#L47 we should also use $contentInfo->getSectionId();

I would disagree with this for the reason mentioned in ibexa/core#348 (comment). Semantic versioning should not allow this.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud