Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7442: Escaped values in JS #1215

Merged
merged 4 commits into from
Mar 19, 2024
Merged

IBX-7442: Escaped values in JS #1215

merged 4 commits into from
Mar 19, 2024

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue IBX-7442
Type bug
Target version v4.5
Required by https://github.com/ibexa/product-catalog/pull/1139
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Mar 15, 2024
@mateuszdebinski mateuszdebinski requested a review from a team March 15, 2024 14:27
@mateuszdebinski mateuszdebinski self-assigned this Mar 15, 2024
@bogusez bogusez self-assigned this Mar 15, 2024
This was referenced Mar 15, 2024
Closed
Closed
@bogusez
Copy link
Contributor

bogusez commented Mar 18, 2024

We will need one more fix and another PR to page builder

Screenshot 2024-03-18 at 10 08 54

tischsoic
tischsoic reviewed Mar 19, 2024
View reviewed changes
src/bundle/Resources/public/js/scripts/core/dropdown.js Outdated Show resolved Hide resolved
src/bundle/Resources/public/js/scripts/helpers/text.helper.js Outdated
Comment on lines 15 to 20
return String(str)
.replace(/&/g, '&')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#039;');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to replace < or >? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mapped the htmlspecialchars functions from PHP and more or less what e('html_attr') does in twig

@mateuszdebinski mateuszdebinski force-pushed the IBX-7442_double_quotes_in_attribute_values branch from 9a4e359 to 16589e6 Compare March 19, 2024 12:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 9838c6d into 4.5 Mar 19, 2024
16 checks passed
@dew326 dew326 deleted the IBX-7442_double_quotes_in_attribute_values branch March 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

@Gengar-i Gengar-i Awaiting requested review from Gengar-i

Assignees

@dew326 dew326

@mateuszdebinski mateuszdebinski

@bogusez bogusez

Labels
Bug Something isn't working QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mateuszdebinski @bogusez @tischsoic @dew326