Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8058: Implemented subscriber that adds content type groups to ContentTypes UI config event #1249

Merged
merged 4 commits into from
May 28, 2024
Merged

IBX-8058: Implemented subscriber that adds content type groups to ContentTypes UI config event #1249

merged 4 commits into from
May 28, 2024

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Apr 19, 2024 •
edited
Loading

🎫 Issue IBX-8058

Related PRs:

Description:

A new event was added to allow adding additional content type groups to UI config event.
The getContentTypeData method now allows to set isHidden parameter as well based on content type group's system property.

@barw4 barw4 self-assigned this Apr 19, 2024
@barw4 barw4 mentioned this pull request Apr 19, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@barw4 barw4 requested a review from a team May 23, 2024 12:11
@mikadamczyk mikadamczyk requested a review from a team May 23, 2024 14:17
@alongosz alongosz requested a review from a team May 23, 2024 14:24
Nattfarinn
Nattfarinn approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Nattfarinn Nattfarinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Konrad about mising FQCN here and there. No other remarks.

@katarzynazawada katarzynazawada mentioned this pull request May 28, 2024
Closed
@barw4 barw4 force-pushed the ibx-8058-implement-adding-content-type-groups-to-ui-config branch from 74b5547 to 8d2ed22 Compare May 28, 2024 08:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 8761339 into 4.6 May 28, 2024
22 checks passed
@alongosz alongosz deleted the ibx-8058-implement-adding-content-type-groups-to-ui-config branch May 28, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

@barw4 barw4

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@barw4 @mikadamczyk @Nattfarinn @alongosz @ViniTou @konradoboza @katarzynazawada @ciastektk