Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3459: js error when trying create content type without defined fields #523

Merged
merged 3 commits into from
Aug 10, 2022
Merged

IBX-3459: js error when trying create content type without defined fields #523

merged 3 commits into from
Aug 10, 2022

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Jul 29, 2022 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-3459
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti force-pushed the IBX-3459-js-error-when-trying-create-content-type-without-defined-fields branch from 9bdf292 to 7d009f1 Compare July 29, 2022 12:33
@lucasOsti lucasOsti added Bug Something isn't working Ready for review labels Jul 29, 2022
@GrabowskiM GrabowskiM changed the title Ibx 3459 js error when trying create content type without defined fields IBX-3459: js error when trying create content type without defined fields Aug 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.1.

@dew326 dew326 merged commit 7e5da3d into 4.1 Aug 10, 2022
@dew326 dew326 deleted the IBX-3459-js-error-when-trying-create-content-type-without-defined-fields branch August 10, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lucasOsti @GrabowskiM @tischsoic @dew326 @tomaszszopinski @mikadamczyk @Nattfarinn