Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3408: Added notice to table #556

Merged
merged 3 commits into from
Sep 5, 2022
Merged

IBX-3408: Added notice to table #556

merged 3 commits into from
Sep 5, 2022

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Aug 25, 2022 •
edited by dew326
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-3408
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

https://github.com/ibexa/product-catalog/pull/771
https://github.com/ibexa/site-factory/pull/51

Screenshot 2022-08-26 at 15 41 17
Screenshot 2022-08-26 at 15 41 29
Screenshot 2022-08-26 at 15 41 09

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti changed the title IBX-3408: Added notice to table [WIP]IBX-3408: Added notice to table Aug 25, 2022
@lucasOsti lucasOsti marked this pull request as draft August 25, 2022 11:57
@lucasOsti lucasOsti changed the title [WIP]IBX-3408: Added notice to table IBX-3408: Added notice to table Aug 26, 2022
@lucasOsti lucasOsti requested review from tischsoic and dew326 and removed request for tischsoic August 26, 2022 14:03
@lucasOsti lucasOsti marked this pull request as ready for review August 26, 2022 14:03
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dew326 dew326 merged commit d916cd6 into main Sep 5, 2022
@dew326 dew326 deleted the IBX-3408-Disclaimer-under-header-in-table branch September 5, 2022 12:22
@mnocon mnocon mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lucasOsti @tischsoic @dew326 @katarzynazawada @mikadamczyk @Nattfarinn