Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3966: Moved UserIdentifier configuration into core #588

Merged
merged 1 commit into from
Oct 14, 2022
Merged

IBX-3966: Moved UserIdentifier configuration into core #588

merged 1 commit into from
Oct 14, 2022

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 4, 2022 •
edited
Loading

Question Answer
Tickets IBX-3966
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

ibexa/core#155

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou requested a review from a team October 4, 2022 06:33
@ViniTou ViniTou force-pushed the moved-user_content_type_identifier branch from bca363d to 6a68e1b Compare October 4, 2022 06:36
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alongosz alongosz requested a review from a team October 10, 2022 14:00
@konradoboza konradoboza requested a review from a team October 11, 2022 06:16
tomaszszopinski
tomaszszopinski approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.3 commerce.

@alongosz alongosz merged commit 79d10d5 into main Oct 14, 2022
@alongosz alongosz deleted the moved-user_content_type_identifier branch October 14, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ViniTou @adamwojs @mikadamczyk @alongosz @konradoboza @tomaszszopinski @Nattfarinn