Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3552: updated focus for dropdown button #631

Merged
merged 1 commit into from Nov 14, 2022

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Nov 2, 2022

Question Answer
Tickets (https://issues.ibexa.co/browse/IBX-3552)
Bug fix? yes
BC breaks? no
Tests pass? yes
License GPL-2.0

Fix for focus box shadow of dropdown

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@Gengar-i Gengar-i changed the base branch from main to 4.2 November 2, 2022 12:59
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@GrabowskiM GrabowskiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but fix PR name to our standards. :)

@Gengar-i Gengar-i changed the title Ibx 3552 wrong dropdown style Ibx 3552: wrong dropdown style Nov 3, 2022
@Gengar-i Gengar-i changed the title Ibx 3552: wrong dropdown style Ibx 3552: updated focus for dropdown button Nov 3, 2022
@Gengar-i Gengar-i changed the title Ibx 3552: updated focus for dropdown button IBX-3552: updated focus for dropdown button Nov 3, 2022
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.2 commerce.

@dew326 dew326 merged commit 49d37f3 into 4.2 Nov 14, 2022
@dew326 dew326 deleted the IBX-3552-wrong-dropdown-style branch November 14, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants