Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4544: Removed menu items from 404 page causing loops and timeouts #673

Merged
merged 1 commit into from
Jan 11, 2023
Merged

IBX-4544: Removed menu items from 404 page causing loops and timeouts #673

merged 1 commit into from
Jan 11, 2023

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Jan 3, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-4544
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? no
License GPL-2.0

This pull request removes menu from 404 page error. The menu appearing on the 404 page resulted in an infinite loop.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@kisztof kisztof requested a review from a team January 3, 2023 13:59
@kisztof kisztof force-pushed the ibx-4544-invalid-request-404 branch from 71af41e to abe4aee Compare January 4, 2023 08:05
@kisztof kisztof force-pushed the ibx-4544-invalid-request-404 branch from abe4aee to 14769ed Compare January 4, 2023 08:24
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.3 commerce.

@webhdx webhdx merged commit 6de48e6 into 4.3 Jan 11, 2023
@webhdx webhdx deleted the ibx-4544-invalid-request-404 branch January 11, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@webhdx webhdx webhdx approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

Labels
QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kisztof @Steveb-p @ciastektk @webhdx @ViniTou @konradoboza @tomaszszopinski @mikadamczyk @Nattfarinn @dew326