Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4972: Middle elippsis fixed container class checked #688

Merged
merged 1 commit into from
Feb 2, 2023
Merged

IBX-4972: Middle elippsis fixed container class checked #688

merged 1 commit into from
Feb 2, 2023

Conversation

Gengar-i
Copy link
Contributor

Question Answer
Tickets IBX-4972
Bug fix? yes
Tests pass? yes
Doc needed? no
License GPL-2.0

Middle elippsis fixed container class checked

Checklist:

  • Coding standards (yarn test)
  • Ready for Code Review

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.3 commerce.

@dew326 dew326 merged commit de50b8e into 4.3 Feb 2, 2023
@dew326 dew326 deleted the ibx-4972-middle-ellipsis-bug branch February 2, 2023 14:54
@Gengar-i
Copy link
Contributor Author

Gengar-i commented Feb 2, 2023

Merge to 4.4: 8427c19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees
No one assigned
Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gengar-i @GrabowskiM @dew326 @lucasOsti @tomaszszopinski