IBX-5255: Move required validation method to helpers #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
force-pushed
the
IBX-5255-required-validator-helper
branch
from
87fff05
to
e46d7b1
Compare
dew326
requested changes
Mar 9, 2023
lucasOsti
approved these changes
Mar 9, 2023
GrabowskiM
force-pushed
the
IBX-5255-required-validator-helper
branch
from
1da42f1
to
513e825
Compare
Gengar-i
reviewed
Mar 9, 2023
| (function (global, doc, ibexa, Translator) { | ||
| const formatErrorLine = (errorMessage) => { | ||
| const errorIcon = `<svg class="ibexa-icon ibexa-icon--small ibexa-form-error__icon"> | ||
| <use xlink:href="${window.ibexa.helpers.icon.getIconPath('warning-triangle')}"></use> |
There was a problem hiding this comment.
Suggested change
| <use xlink:href="${window.ibexa.helpers.icon.getIconPath('warning-triangle')}"></use> | |
| <use xlink:href="${ibexa.helpers.icon.getIconPath('warning-triangle')}"></use> |
|
|
||
| return container; | ||
| }; | ||
| const checkIsEmpty = (field) => { |
There was a problem hiding this comment.
I dont like this func name
dew326
reviewed
Mar 9, 2023
| ibexa.addConfig('helpers.formError', { | ||
| formatLine, | ||
| formatLine: (...args) => { | ||
| console.warn('helpers.formError.formatLine method is deprecated and will be removed in 5.0'); |
There was a problem hiding this comment.
please use ... instead - when deprecating things you should show how to fix it.
GrabowskiM
force-pushed
the
IBX-5255-required-validator-helper
branch
2 times, most recently
from
02ecef9
to
7dac0bb
Compare
dew326
approved these changes
Mar 10, 2023
Gengar-i
approved these changes
Mar 10, 2023
tischsoic
approved these changes
Mar 10, 2023
GrabowskiM
force-pushed
the
IBX-5255-required-validator-helper
branch
from
d1811e4
to
adf77cc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)