Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5863: Adjust reschedule modal for long labels in buttons #829

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5863
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM changed the base branch from main to 4.5 June 29, 2023 15:01
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez bogusez self-assigned this Jul 4, 2023
@bogusez
Copy link
Contributor

bogusez commented Jul 4, 2023

@GrabowskiM something is wrong here, the modal window is too wide

Screenshot 2023-07-04 at 08 00 32

@GrabowskiM
Copy link
Contributor Author

@GrabowskiM something is wrong here, the modal window is too wide

Screenshot 2023-07-04 at 08 00 32

That's correct width, there is design for it https://www.figma.com/file/C84ggnTTrPZa2X0dj23IQ7/Bugs?type=design&node-id=101-307548&mode=design&t=3Irs8X8ZpB58kmGN-0 and this modal should have now 800px.
Sorry, I should paste this link into issue as well - now there's link, but I did it few minutes ago. :)

@bogusez
Copy link
Contributor

bogusez commented Jul 5, 2023

Regression tests passed:
ibexa/commerce#298
ibexa/experience#200

@dew326 dew326 merged commit 912a994 into 4.5 Jul 5, 2023
@dew326 dew326 deleted the IBX-5863-reschedule-modal branch July 5, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants