Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4172: Fixed jumping headline in content structure #841

Merged
merged 1 commit into from
Aug 3, 2023
Merged

IBX-4172: Fixed jumping headline in content structure #841

merged 1 commit into from
Aug 3, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Jul 20, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-4172
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326 dew326 self-assigned this Jul 20, 2023
@dew326 dew326 changed the base branch from main to 4.5 July 20, 2023 06:16
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.5

@mikadamczyk mikadamczyk merged commit bf31e96 into 4.5 Aug 3, 2023
@mikadamczyk mikadamczyk deleted the fix-headline-jump branch August 3, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@ViniTou ViniTou ViniTou approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dew326 @mikadamczyk @GrabowskiM @ViniTou @lucasOsti @Gengar-i @tomaszszopinski @Nattfarinn @ciastektk