Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3675: Fix unavailable state styling of PB sidebar blocks (d&d) #845

Merged
merged 1 commit into from
Aug 7, 2023
Merged

IBX-3675: Fix unavailable state styling of PB sidebar blocks (d&d) #845

merged 1 commit into from
Aug 7, 2023

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Jul 20, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-3675
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Related PRs:

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@tischsoic tischsoic self-assigned this Jul 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tischsoic
tischsoic commented Jul 20, 2023
View reviewed changes
src/bundle/Resources/public/scss/mixins/_drag-and-drop.scss
@@ -171,15 +171,18 @@
}

&--unavailable {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I haven't found any place where this modifier (BEM) was used and its styling seemed to be incorrect.

@tischsoic tischsoic changed the base branch from main to 4.5 July 21, 2023 13:26
tomaszszopinski
tomaszszopinski approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.5 commerce.

@ViniTou ViniTou merged commit 03d6019 into 4.5 Aug 7, 2023
@ViniTou ViniTou deleted the IBX-3675-fix-unavailable-state-styling-of-sidebar-blocks branch August 7, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@ViniTou ViniTou ViniTou approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@tischsoic tischsoic

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tischsoic @GrabowskiM @dew326 @ViniTou @lucasOsti @Gengar-i @tomaszszopinski