Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6314: Apply microcopy guidelines and adjust translation keys and domains #866

Merged
merged 21 commits into from
Sep 1, 2023

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Aug 9, 2023

@tischsoic tischsoic marked this pull request as ready for review August 30, 2023 07:39
@tischsoic tischsoic force-pushed the fix-translations branch 2 times, most recently from dcc53e7 to 15eae92 Compare August 30, 2023 13:28
@tischsoic tischsoic requested a review from a team September 1, 2023 08:54
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about PHPStan fail?

composer.json Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team September 1, 2023 09:08
@tischsoic tischsoic requested review from a team September 1, 2023 09:40
@tischsoic
Copy link
Contributor Author

Regression tests in: ibexa/commerce#365
One test not passing: https://github.com/ibexa/commerce/actions/runs/6049111907/job/16415778809?pr=365#step:16:26
11/78 ✘ 1 min 28 s 868 ms /var/www/vendor/ibexa/product-catalog/features/browser/Catalogs.feature
but tests in https://github.com/ibexa/product-catalog/pull/1041 passed after a later fix in admin-ui,
so everything should be okay.

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
5.6% 5.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@tischsoic tischsoic merged commit 8be2b3c into main Sep 1, 2023
12 of 14 checks passed
@tischsoic tischsoic deleted the fix-translations branch September 1, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants