IBX-6252: Update hover styles for --selector button #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gengar-i
reviewed
Aug 28, 2023
| @@ -307,6 +307,7 @@ | |||
| color: $ibexa-color-dark; | |||
| fill: $ibexa-color-dark; | |||
| padding: calculateRem(11px) calculateRem(12px); | |||
| pointer-events: auto; | |||
There was a problem hiding this comment.
Property pointer-events: auto is default value.
Shouldn't we delete all of the pointer-events: none values instead?
There was a problem hiding this comment.
Personally I would do such change in new PR/issue, as removing pointer-events: none from all buttons (what you propose if I understand correctly) touches all system, I'd rather not do such big change in this feature PR.
What other thinks? @dew326 @lucasOsti @tischsoic
lucasOsti
approved these changes
Aug 30, 2023
dew326
approved these changes
Aug 31, 2023
GrabowskiM
force-pushed
the
IBX-6252-pb-history
branch
from
a5f3e26
to
943b586
Compare
GrabowskiM
force-pushed
the
IBX-6252-pb-history
branch
from
943b586
to
76c9b6b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tischsoic
approved these changes
Sep 6, 2023
Gengar-i
approved these changes
Sep 7, 2023
tomaszszopinski
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
title/hover on disabled button doesn't work
Checklist:
$ composer fix-cs)