IBX-6599: New grid view item design #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
reviewed
Sep 19, 2023
| border: calculateRem(1px) solid $ibexa-color-light; | ||
| border-radius: calculateRem(5px); | ||
| border-radius: calculateRem(12px); |
There was a problem hiding this comment.
we have variable for 5px nad 10px, should we add this too?
There was a problem hiding this comment.
Not sure, design says 12px.
There was a problem hiding this comment.
Discussed in private: we agreed that for now, we will be using 12px without any variable.
dew326
approved these changes
Sep 20, 2023
GrabowskiM
approved these changes
Sep 21, 2023
Gengar-i
approved these changes
Sep 25, 2023
tischsoic
force-pushed
the
IBX-6599-new-grid-item-design
branch
from
f72e92a
to
1ab2d74
Compare
katarzynazawada
requested changes
Oct 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Checklist:
$ composer fix-cs)