Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6377: Wrong table color in RTE in content preview #928

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6377
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Oct 10, 2023
@micszo
Copy link
Contributor

micszo commented Oct 10, 2023

Please cover preview / frontend also so that we can address https://issues.ibexa.co/browse/IBX-6560 too. 🙂

@GrabowskiM
Copy link
Contributor Author

Please cover preview / frontend also so that we can address https://issues.ibexa.co/browse/IBX-6560 too. 🙂

Answered by Darek in issue (that we'd rather not style anything on frontend and it should be partner responsibility with some more explanation)

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retest OK.

QA Approved on Ibexa Commerce 4.5.4-dev.

@micszo micszo removed their assignment Oct 12, 2023
@dew326 dew326 merged commit 24fbde0 into 4.5 Oct 13, 2023
14 checks passed
@dew326 dew326 deleted the IBX-6377-table-color branch October 13, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants