IBX-6718: Missing scroll in language dropdown #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
force-pushed
the
IBX-6718-react-dropdown-scroll-height-fix
branch
from
6a0e027
to
e7c4fe0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lucasOsti
approved these changes
Oct 10, 2023
dew326
approved these changes
Oct 10, 2023
Gengar-i
approved these changes
Oct 10, 2023
katarzynazawada
approved these changes
Oct 17, 2023
tischsoic
reviewed
Feb 21, 2024
| itemsStyles.top = top + height + ITEMS_LIST_WIDGET_MARGIN; | ||
| itemsStyles.maxHeight = window.innerHeight - bottom - ITEMS_LIST_SITE_MARGIN; | ||
| } else { | ||
| const headerContainer = document.querySelector('.ibexa-main-header'); |
There was a problem hiding this comment.
Note: we were wondering in last few days why ibexa-main-header offsetHeight was introduced so if you also wonder, you can find the explanation in this comment: #1183 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
Checklist:
$ composer fix-cs)