Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6872: As the User I want to see new design for badges #952

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6872
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrabowskiM colours for Draft and Published catalog need to be changed
Screenshot 2023-11-06 at 12 05 26
Screenshot 2023-11-06 at 12 05 15

Also wrong style of Active/Inactive shipping/payment method
Screenshot 2023-11-06 at 12 10 56
Screenshot 2023-11-06 at 12 10 36

Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 places need to be changed according to newest design
Screenshot 2023-11-30 at 15 15 09
Screenshot 2023-11-30 at 15 15 26

Screenshot 2023-11-30 at 14 27 50

@GrabowskiM GrabowskiM force-pushed the IBX-6872-new-design-for-badges branch from 1885dce to d3c695a Compare December 1, 2023 07:43
@GrabowskiM GrabowskiM force-pushed the IBX-6872-new-design-for-badges branch from d3c695a to 3bfb3b5 Compare December 1, 2023 14:56
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dew326 dew326 merged commit 05d42a5 into main Dec 5, 2023
23 checks passed
@dew326 dew326 deleted the IBX-6872-new-design-for-badges branch December 5, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants