IBX-6843: Focus mode #955
Merged
IBX-6843: Focus mode #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-6843-focus-mode
branch
8 times, most recently
from
c61a624
to
8581f21
Compare
GrabowskiM
requested changes
Oct 30, 2023
|
|
||
| doc.body.addEventListener( | ||
| ENABLE_FOCUS_MODE_EVENT_NAME, | ||
| () => doc.body.addEventListener('keydown', watchDisableFocusModeByKeyboard), |
There was a problem hiding this comment.
Suggested change
| () => doc.body.addEventListener('keydown', watchDisableFocusModeByKeyboard), | |
| () => doc.body.addEventListener('keydown', watchDisableFocusModeByKeyboard, false), |
There was a problem hiding this comment.
We use it everywhere like this but u know @GrabowskiM its default false? 🧆
| } | ||
| }; | ||
| const watchDisableFocusModeByKeyboard = (event) => { | ||
| if (event.key === 'Escape' || event.keyCode === 27) { |
There was a problem hiding this comment.
Suggested change
| if (event.key === 'Escape' || event.keyCode === 27) { | |
| if (event.key === 'Escape') { |
| @@ -270,7 +270,6 @@ | |||
|
|
|||
| {%- block richtext_widget -%} | |||
| {% set attr = attr|merge({ 'hidden': true }) %} | |||
|
|
|||
There was a problem hiding this comment.
unnecessary deletion :)
| </svg> | ||
| {%- endset -%} | ||
| {%- set title -%} | ||
| {{ 'focus_mode.disbale_hint'|trans({ '%icon%': title_icon|raw })|desc('To exit focus mode, click the %icon% or press Esc')|raw }} |
There was a problem hiding this comment.
Suggested change
| {{ 'focus_mode.disbale_hint'|trans({ '%icon%': title_icon|raw })|desc('To exit focus mode, click the %icon% or press Esc')|raw }} | |
| {{ 'focus_mode.disable_hint'|trans({ '%icon%': title_icon|raw })|desc('To exit focus mode, click the %icon% or press Esc')|raw }} |
Gengar-i
reviewed
Oct 31, 2023
|
|
||
| .ibexa-field-edit { | ||
| &__focus-mode { | ||
| margin: auto 0 0 0; |
There was a problem hiding this comment.
Suggested change
| margin: auto 0 0 0; | |
| margin: auto 0 0; |
Comment on lines
3
to
4
| const ENABLE_FOCUS_MODE_EVENT_NAME = 'ibexa-focus-mode:on'; | ||
| const DISABLE_FOCUS_MODE_EVENT_NAME = 'ibexa-focus-mode:off'; |
There was a problem hiding this comment.
Maybe?
Suggested change
| const ENABLE_FOCUS_MODE_EVENT_NAME = 'ibexa-focus-mode:on'; | |
| const DISABLE_FOCUS_MODE_EVENT_NAME = 'ibexa-focus-mode:off'; | |
| const FOCUS_MODE_ON_EVENT = 'ibexa-focus-mode:on'; | |
| const FOCUS_MODE_OFF_EVENT = 'ibexa-focus-mode:off'; |
Suggested change
| const ENABLE_FOCUS_MODE_EVENT_NAME = 'ibexa-focus-mode:on'; | |
| const DISABLE_FOCUS_MODE_EVENT_NAME = 'ibexa-focus-mode:off'; | |
| const FOCUS_MODE_ENABLE_EVENT = 'ibexa-focus-mode:enable'; | |
| const FOCUS_MODE_DISABLE_EVENT = 'ibexa-focus-mode:disable'; |
| @@ -0,0 +1,61 @@ | |||
| (function (global, doc) { | |||
There was a problem hiding this comment.
Maybe stick to one logic enable/disable || on/off?
| activeFieldEdit = null; | ||
| } | ||
| }; | ||
| const watchDisableFocusModeByKeyboard = (event) => { |
There was a problem hiding this comment.
Why we always add Keyboard with func name for keydown but never Click when using click? 😄
Maybe exitFocusMode || exitFocusModeByKeyboard
| overflow-y: auto; | ||
| align-self: stretch; | ||
| flex-grow: 1; | ||
| padding: calculateRem(8px) calculateRem(32px) calculateRem(32px) calculateRem(32px); |
There was a problem hiding this comment.
Suggested change
| padding: calculateRem(8px) calculateRem(32px) calculateRem(32px) calculateRem(32px); | |
| padding: calculateRem(8px) calculateRem(32px) calculateRem(32px); |
lucasOsti
force-pushed
the
IBX-6843-focus-mode
branch
from
102de3f
to
7861b7d
Compare
GrabowskiM
approved these changes
Nov 2, 2023
Gengar-i
approved these changes
Nov 2, 2023
lucasOsti
force-pushed
the
IBX-6843-focus-mode
branch
from
7861b7d
to
5b028ae
Compare
Gengar-i
approved these changes
Nov 3, 2023
GrabowskiM
approved these changes
Nov 3, 2023
dew326
approved these changes
Nov 6, 2023
4 tasks
lucasOsti
force-pushed
the
IBX-6843-focus-mode
branch
from
87fa2f0
to
7440479
Compare
micszo
reviewed
Nov 15, 2023
micszo
force-pushed
the
IBX-6843-focus-mode
branch
from
efac032
to
c7fdb2f
Compare
micszo
force-pushed
the
IBX-6843-focus-mode
branch
from
c7fdb2f
to
76c827b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dew326
approved these changes
Nov 17, 2023
micszo
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR's
Normal view
Focus mode view
Checklist:
$ composer fix-cs)