New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7086: Widget to change site context #994

Merged

adamwojs merged 2 commits into main from IBX-7086-widget-to-change-sa-context

Nov 20, 2023

Contributor

GrabowskiM commented Nov 17, 2023

Question	Answer
Tickets	https://issues.ibexa.co/browse/IBX-7086
Bug fix?	no
New feature?	yes
BC breaks?	no
Tests pass?	yes
Doc needed?	no
License	GPL-2.0

Checklist:

Coding standards ($ composer fix-cs)
Ready for Code Review

github-actions bot assigned ciastektk, dew326, mikadamczyk, Nattfarinn and ViniTou

GrabowskiM force-pushed the IBX-7086-widget-to-change-sa-context branch from 54916a9 to efc78b8 Compare

November 17, 2023 14:42


          IBX-7086: Widget to change siteAccess context

ca72515

GrabowskiM force-pushed the IBX-7086-widget-to-change-sa-context branch from efc78b8 to ca72515 Compare

November 17, 2023 14:46

GrabowskiM requested review from lucasOsti, tischsoic, dew326 and Gengar-i

November 17, 2023 14:48

lucasOsti reviewed

View reviewed changes

src/bundle/Resources/views/themes/admin/ui/component/dropdown/dropdown.html.twig Outdated

@@ @@ -20,6 +20,8 @@ @@
               {% set has_select_all_toggler = has_select_all_toggler|default(false) %}
               {% set item_icon = item_icon|default() %}
               {% set item_icon_class = item_icon_class|default('') %}
+              {% set selected_item_template_name = selected_item_template_name|default('@ibexadesign/ui/component/dropdown/dropdown_selected_item.html.twig') %}

Contributor

lucasOsti Nov 17, 2023

is it a name or a path?

tischsoic approved these changes

View reviewed changes

GrabowskiM requested a review from lucasOsti

November 20, 2023 11:26


          name to path

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

dew326 approved these changes

View reviewed changes

lucasOsti approved these changes

View reviewed changes

adamwojs changed the title ~~IBX-7086: Widget to change siteAccess context~~ IBX-7086: Widget to change site context

adamwojs merged commit 639e7fc into main

23 of 24 checks passed

adamwojs deleted the IBX-7086-widget-to-change-sa-context branch

November 20, 2023 20:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet