Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed builds when a package has dependencies on other branches #82

Closed
wants to merge 1 commit into from

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Dec 21, 2023

Current situation:
When the composer.json is modified to include dependencies on other branches then the dependencies.json is not enough to run the Browser tests - the build will fail before the file is even parsed.

This PR moves the parsing of dependencies.json before the Ibexa main package (oss, headless, experience, commerce) is added so that Composer is aware that additional dev packages will be needed.

Example failure:
https://github.com/ibexa/rest/actions/runs/7287087802/job/19857028341?pr=82

TODO:

  1. Check that it works in normal regression builds
  2. Check that it works when a PR with modified composer.json is included in a regression
  3. Copy the solution to other scripts (3.3, 4.5)

Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mnocon mnocon marked this pull request as ready for review February 15, 2024 13:39
@mnocon mnocon marked this pull request as draft February 15, 2024 14:04
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mnocon
Copy link
Contributor Author

mnocon commented Mar 14, 2024

This is broken on 4.6 only, because of these PRs:
#76
#73

So:

  1. Dependencies should be added after behat and docker, to allow overwriting them
  2. Dependencies should be added before the Ibexa package, to stop the changes from package's composer.json from failing the build
  3. docker should be added after the Ibexa package, otherwise Moved ibexa/behat and ibexa/docker installation #73 happens

looks like an order like this is not possible - and another solution would be needed.

Closing this one, it needs another approach

@mnocon mnocon closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants