Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2901: Added Aliases for Security Providers #109

Merged
merged 3 commits into from
May 16, 2022
Merged

IBX-2901: Added Aliases for Security Providers #109

merged 3 commits into from
May 16, 2022

Conversation

reithor
Copy link
Contributor

@reithor reithor commented May 13, 2022 •
edited
Loading

Question Answer
JIRA issue IBX-2901
Type bug
Target Ibexa version 4.1
BC breaks no

Configuration according https://doc.ibexa.co/en/latest/guide/user_management/user_management/#login-methods needs service ids ibexa.security.user_provider.username and ibexa.security.user_provider.email

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@reithor reithor marked this pull request as ready for review May 13, 2022 14:38
@reithor
Copy link
Contributor Author

reithor commented May 13, 2022

ping @ibexa/engineering

@reithor reithor requested a review from ViniTou May 13, 2022 14:39
alongosz
alongosz requested changes May 13, 2022
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reithor Ibexa DXP 4.0 is past EOM since the end of April. We can accept the fix for Ibexa DXP 4.1 (branch 4.1).

@reithor reithor changed the base branch from 4.0 to 4.1 May 13, 2022 18:01
@reithor reithor requested a review from alongosz May 13, 2022 18:06
@reithor
Copy link
Contributor Author

reithor commented May 13, 2022

@reithor Ibexa DXP 4.0 is past EOM since the end of April.
@alongosz was not aware of this - changed PR accordingly

@alongosz alongosz requested a review from a team May 13, 2022 21:18
@adamwojs adamwojs merged commit d07027d into 4.1 May 16, 2022
@adamwojs adamwojs deleted the ib-2901-added-security-providers-aliases branch May 16, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@glye glye glye approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@damianz5 damianz5 damianz5 approved these changes

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@reithor @adamwojs @glye @Steveb-p @damianz5 @alongosz @konradoboza @katarzynazawada @mikadamczyk @ciastektk