IBX-4452: Moved logic to convert Limitation identifier into Label #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisztof
force-pushed
the
ibx-4452-deprecate-translation-extractors
branch
2 times, most recently
from
8a5aa1e
to
a015885
Compare
2 tasks
kisztof
force-pushed
the
ibx-4452-deprecate-translation-extractors
branch
from
a015885
to
ee50a4d
Compare
kisztof
force-pushed
the
ibx-4452-deprecate-translation-extractors
branch
from
ee50a4d
to
b18ac8e
Compare
alongosz
reviewed
Dec 19, 2022
alongosz
approved these changes
Dec 19, 2022
ViniTou
approved these changes
Dec 19, 2022
konradoboza
approved these changes
Dec 19, 2022
tests/lib/Limitation/LimitationLabelIdentifierConverterTest.php
Outdated
Show resolved
Hide resolved
Steveb-p
approved these changes
Dec 19, 2022
tests/lib/Limitation/LimitationLabelIdentifierConverterTest.php
Outdated
Show resolved
Hide resolved
mikadamczyk
reviewed
Dec 19, 2022
webhdx
approved these changes
Dec 19, 2022
mikadamczyk
approved these changes
Dec 19, 2022
kisztof
force-pushed
the
ibx-4452-deprecate-translation-extractors
branch
from
0ef02bf
to
818971c
Compare
kisztof
requested review from
konradoboza,
ViniTou,
Steveb-p,
mikadamczyk and
webhdx
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
alongosz
approved these changes
Dec 19, 2022
mikadamczyk
approved these changes
Dec 19, 2022
| namespace Ibexa\Core\Limitation; | ||
|
|
||
| /** | ||
| * @internal |
There was a problem hiding this comment.
Suggested change
| * @internal |
Steveb-p
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.4This PR moved logic from method LimitationTranslationExtractor::identifierToLabel() caused by admin-ui's LimitationTranslationExtractor class deprecation to a new class.
ibexa/admin-ui#662
Checklist:
$ composer fix-cs).@ibexa/engineering).