-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-3740: Prepended default Core settings #182
Conversation
5cad3cb
to
f223be2
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A summary of my tests on Commerce 4.3:
-
DFS/NFS worked for me on mysql and postgres with this fix. 👍🏻
-
On Platform.sh with Elastic the
elasticsearch_dsn
parameter in my tests was still not set correctly with this fix.
I consulted with @vidarl and using his patch instead Elastic worked correctly on p.sh.
I think the three of us need to sync next week, either I am missing something or we are missing something here.
Hi, While testing on Experience 4.4 and 4.5 (not 4.3), |
f223be2
to
4ea8343
Compare
4ea8343
to
325a873
Compare
Quality Gate passedIssues Measures |
@micszo ibexa/recipes-dev#112 should be enough to fix the issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with DFS/NFS. Setup via env vars works fine now.
QA Approved on Ibexa Commerce 4.5.7-dev.
v4.5
+This PR foremost moves loading default settings into
prepend
stage. My initial idea was to move everything intoload
stage, however processing merged project configuration foribexa
extension is occurs beforeIbexaCoreExtension::load
stage, therefore some of settings created byconfigureGenericSetup
need to be available beforeload
as well (e.g.purge_type
parameter value).Some side issues were fixed as well:
ibexa.persistence.legacy.dsn
parameter valueQA
All issues reported in IBX-3740 should be resolved by this. We need to focus on DFS configuration as it affects Flysystem v2 upgrade.
Scope: It affects both standalone installation and Platform.sh.
Checklist:
$ composer fix-cs
).