Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4452: Added missing line of translation #187

Merged
merged 1 commit into from
Dec 23, 2022
Merged

IBX-4452: Added missing line of translation #187

merged 1 commit into from
Dec 23, 2022

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Dec 23, 2022

Question Answer
JIRA issue IBX-4452
Type improvement
Target Ibexa version v4.4
BC breaks no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@kisztof kisztof marked this pull request as ready for review December 23, 2022 11:16
@kisztof kisztof requested a review from a team December 23, 2022 11:16
@kisztof kisztof added Fast-forward merge PR should be merged in a fast-forward way Improvement Ready for review labels Dec 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kisztof kisztof removed the Fast-forward merge PR should be merged in a fast-forward way label Dec 23, 2022
@alongosz alongosz merged commit bcfadcf into main Dec 23, 2022
@alongosz alongosz deleted the ibx-4452-missig-translation-xliff branch December 23, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Improvement Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kisztof @alongosz @konradoboza @adamwojs @mikadamczyk @Steveb-p @ciastektk