Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5385: Added option content-type to reindex command #259

Merged
merged 6 commits into from
Sep 19, 2023
Merged

IBX-5385: Added option content-type to reindex command #259

merged 6 commits into from
Sep 19, 2023

Conversation

papcio122
Copy link
Contributor

@papcio122 papcio122 commented Aug 9, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-5385
Type improvement
Target Ibexa version v4.5
BC breaks no

As title says

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@papcio122 papcio122 changed the base branch from main to 4.5 September 8, 2023 08:03
@papcio122 papcio122 mentioned this pull request Sep 8, 2023
Closed
6 tasks
@papcio122 papcio122 force-pushed the IBX-5385_add_content-type_option_to_reindex_command branch from 6f02412 to 76557f4 Compare September 11, 2023 14:02
@papcio122 papcio122 force-pushed the IBX-5385_add_content-type_option_to_reindex_command branch from f89cc1b to 2354584 Compare September 12, 2023 08:10
@papcio122 papcio122 marked this pull request as ready for review September 12, 2023 09:15
@papcio122 papcio122 requested a review from a team September 12, 2023 09:15
Steveb-p
Steveb-p requested changes Sep 12, 2023
View reviewed changes
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
@alongosz alongosz self-requested a review September 12, 2023 16:08
@alongosz alongosz changed the title Added option content-type to reindex command IBX-5385: Added option content-type to reindex command Sep 13, 2023
alongosz
alongosz reviewed Sep 13, 2023
View reviewed changes
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
src/bundle/Core/Command/ReindexCommand.php Outdated Show resolved Hide resolved
@alongosz alongosz requested a review from a team September 13, 2023 11:26
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz requested a review from a team September 14, 2023 06:44
@konradoboza konradoboza requested a review from a team September 14, 2023 07:01
@bogusez bogusez self-assigned this Sep 19, 2023
This was referenced Sep 19, 2023
Closed
Closed
Closed
Closed
@bogusez
Copy link

bogusez commented Sep 19, 2023

Regression tests passed:
ibexa/oss#116
ibexa/content#101
ibexa/experience#236
ibexa/commerce#388

@alongosz alongosz merged commit 6c05d9f into 4.5 Sep 19, 2023
22 checks passed
@alongosz alongosz deleted the IBX-5385_add_content-type_option_to_reindex_command branch September 19, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

@bogusez bogusez

Labels
QA approved Ready for MERGE Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@papcio122 @bogusez @Steveb-p @alongosz @konradoboza @kisztof @mikadamczyk