-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-6827: Aggregation API improvements #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
konradoboza
approved these changes
Dec 11, 2023
alongosz
reviewed
Dec 11, 2023
src/contracts/Repository/Values/Content/Query/Aggregation/Range.php
Outdated
Show resolved
Hide resolved
...contracts/Repository/Values/Content/Query/Aggregation/Ranges/DateTimeStepRangesGenerator.php
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/Query/Aggregation/Ranges/FloatStepRangesGenerator.php
Outdated
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/Query/Aggregation/Ranges/IntegerStepRangesGenerator.php
Outdated
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/Query/Aggregation/Ranges/RangesGeneratorInterface.php
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
alongosz
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6
This PR introduces several small Aggregation API improvements (DX).
Range::INF
Ibexa\Contracts\Core\Repository\Values\Content\Query\Aggregation\Range::INF
const allows developers to be more verbose when defining open ranges:Range labels
Added
label
property with accessors to\Ibexa\Contracts\Core\Repository\Values\Content\Query\Aggregation\Range
class.Labels can used latter on to render aggregation results.
Simplified access to Term & Range Aggregations Result keys
It's very common to use term aggregations to get top N terms e.g 10 most popular categories.
In this use case we are not interested into how many object belongs to specific bucket.
\Ibexa\Contracts\Core\Repository\Values\Content\Search\AggregationResult\TermAggregationResult::getKeys
method allows to retrieve terms without need to manually iterate over result entries.Ranges generators
Step generators
Related PRs:
Checklist:
$ composer fix-cs
).@ibexa/engineering
).