Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1543: Replaced deprecated twig functions #29

Merged
merged 16 commits into from
Dec 2, 2021
Merged

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Dec 1, 2021

Question Answer
JIRA issue IBX-1543
Type improvement
Target Ibexa version v4.0
BC breaks no

ibexa/admin-ui#77
https://github.com/ibexa/commerce-admin-ui/pull/13
https://github.com/ibexa/commerce-base-design/pull/5
https://github.com/ibexa/commerce-checkout/pull/3
https://github.com/ibexa/commerce-order-history/pull/4
https://github.com/ibexa/commerce-fieldtypes/pull/5
https://github.com/ibexa/commerce-price-engine/pull/3
https://github.com/ibexa/commerce-shop/pull/13
https://github.com/ibexa/commerce-shop-ui/pull/5
https://github.com/ibexa/commerce-transaction/pull/7
https://github.com/ibexa/connector-dam/pull/4
ibexa/content-forms#6
https://github.com/ibexa/fieldtype-page/pull/13
ibexa/fieldtype-query#4
ibexa/fieldtype-richtext#4
https://github.com/ibexa/form-builder/pull/18
ibexa/http-cache#5
https://github.com/ibexa/page-builder/pull/34
https://github.com/ibexa/personalization/pull/15
ibexa/personalization-client#16
https://github.com/ibexa/scheduler/pull/21
ibexa/search#4
https://github.com/ibexa/segmentation/pull/7
https://github.com/ibexa/site-factory/pull/7
ibexa/system-info#7
ibexa/user#7
https://github.com/ibexa/version-comparison/pull/9
https://github.com/ibexa/workflow/pull/13

and that one already merged: :D
https://github.com/ibexa/product-catalog/pull/193

What was done:

  • unifed prefix ibexa_ and ibexa_commerce for twig functions and filters
  • find & replace for occurences
  • in some cases, deprecated and removed method Twig_ExtensionInterface::getName was removed from implementations.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@ViniTou ViniTou merged commit e766878 into main Dec 2, 2021
@ViniTou ViniTou deleted the ibx-1543-twig-functions branch December 2, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants