-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7236: Added support of % on both sides of a 'like' statement in fulltext criterion #298
Conversation
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/FullText.php
Outdated
Show resolved
Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/FullText.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see some integration coverage for this use case. Looks rather complicated, even though it's just ~8 LOC.
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/FullText.php
Outdated
Show resolved
Hide resolved
[ | ||
'*row*', | ||
[[2, 5, 8, 9, 11, 12, 14, 15]], | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a closer look this test doesn't test anything related to the changes. See that this entire test case is meant for advanced search capabilities. LSE does not offer them so the test gets skipped.
The test can stay to ensure feature parity (we want this to work on Solr and it seems it's doing that OOTB), but we need dedicated test testing that FullText criterion used on LSE is working too, since you're changing LSE behavior.
Prepare a content with some TextLine (ezstring) containing phrases and add several cases (negative and positive ones). Think it through - what you expect from this feature, what is not desired?
28b8f2b
to
0dcb48a
Compare
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
0dcb48a
to
9aca6a1
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Closing as obsolete |
v4.6
This PR adds support of % on both sides of like statement in fulltext criterion
Checklist:
$ composer fix-cs
).@ibexa/engineering
).