Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7717: Introduced strict getters for LookupLimitationResult and VersionInfo Value Object #349

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 15, 2024

Question Answer
JIRA issue IBX-7717
Required by ibexa/admin-ui#1197
Target Ibexa version v4.5
BC breaks no

Introducing strict getters for LookupLimitationResult for the issue detected by PHPStan in ibexa/admin-ui#1197.
Alternatively we could add @property-read PHPDoc, but as agreed, we're no longer doing magic.

Also added strict properties. Reasoning: given the class already has declared strict types and the properties can be set only by strictly-typed constructor, it shouldn't be possible to have code which would set something else for these properties.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.5 commerce.

@alongosz alongosz changed the title IBX-7717: Introduced strict getters for LookupLimitationResult Value Object IBX-7717: Introduced strict getters for LookupLimitationResult and VersionInfo Value Object Apr 9, 2024
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 26f59d8 into 4.5 Apr 10, 2024
25 checks passed
@alongosz alongosz deleted the ibx-7717-add-getters-for-lookup-limitation-result branch April 10, 2024 10:28
@tischsoic
Copy link
Contributor

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants