-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHPDoc] Improved ContentService doc for API reference #379
Conversation
0700fc8
to
f33c2e7
Compare
@adriendupuis Could you please address issues reported by phpstan? |
@adriendupuis this one needs rebase. Are all prior review remarks resolved and is it ready for another round of review? |
b77b3c9
to
76f9c88
Compare
Quality Gate passedIssues Measures |
Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
76f9c88
to
dc5dcff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as https://github.com/ibexa/core/pull/379/files#r1828007119 and similar are applied.
Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
Quality Gate passedIssues Measures |
Description:
Enhance
ContentService
doc:ContentService::loadContent
)@thows
, trailing period, etc.)@see
, etc.)PHP API Reference output:
Notice that by inheritance, it also changes the doc for
ContentServiceDecorator
:For QA:
Documentation: