Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1689: Change all ez- classes/IDs and eZ variables in frontend part #38

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Dec 13, 2021

Question Answer
JIRA issue IBX-1689
Type improvement
Target Ibexa version v4.0
BC breaks yes

Changed all eZ/ez- frontend classes/variables to ibexa

Related PRs:

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@@ -8,25 +8,25 @@
{% trans_default_domain "fielddefinition" %}

{% block ezstring_settings %}
<ul class="ez-fielddefinition-settings ez-fielddefinition-{{ fielddefinition.fieldTypeIdentifier }}-settings">
<ul class="ibexa-fielddefinition-settings ibexa-fielddefinition-{{ fielddefinition.fieldTypeIdentifier }}-settings">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ul class="ibexa-fielddefinition-settings ibexa-fielddefinition-{{ fielddefinition.fieldTypeIdentifier }}-settings">
<ul class="ibexa-field-definition-settings ibexa-field-definition-{{ fielddefinition.fieldTypeIdentifier }}-settings">

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be outside scope of this PR - I don't think @GrabowskiM is supposed to fix all CSS classes. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside scope, I only change ez/ezplatform to ibexa, otherwise these PR would be three times longer. :)

@dew326 dew326 force-pushed the IBX-1689-rename-ez-to-ibexa-front branch from 8512876 to 1228eec Compare December 21, 2021 08:12
@dew326 dew326 merged commit 201dcc7 into main Dec 21, 2021
@dew326 dew326 deleted the IBX-1689-rename-ez-to-ibexa-front branch December 21, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants