Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2349/5244/5245: Added possibility to add link into embed image #78

Merged
merged 3 commits into from
Mar 23, 2023
Merged

IBX-2349/5244/5245: Added possibility to add link into embed image #78

merged 3 commits into from
Mar 23, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Mar 17, 2023 •
edited
Loading

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-2349 https://issues.ibexa.co/browse/IBX-5245 https://issues.ibexa.co/browse/IBX-5244
Bug yes
New feature no
Target version 4.4
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Mar 17, 2023
@dew326 dew326 requested a review from GrabowskiM March 17, 2023 13:42
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jwibexa jwibexa self-assigned this Mar 22, 2023
jwibexa
jwibexa approved these changes Mar 23, 2023
View reviewed changes
Copy link

@jwibexa jwibexa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested Tested and validated on 4.5 experience FF and chrome
Tests on 4.4 passed https://github.com/ibexa/experience/pull/159/checks

@dew326 dew326 merged commit 38e6ff9 into 4.4 Mar 23, 2023
@dew326 dew326 deleted the links-embed-image branch March 23, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwibexa jwibexa jwibexa approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

@jwibexa jwibexa

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dew326 @GrabowskiM @tischsoic @lucasOsti @Gengar-i @jwibexa @alongosz