IBX-7979: Fixed "field" occurrences being wrongly replaced #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.ibexa.co/browse/IBX-7979
Performing simple
str_replace
on fieldtypes' identifiers likemy_custom_field
instead ofproduced something like:
which is obviously an invalid schema entry.
Decided to just narrow down the actual replacing to values not being inside double quotes. The reason for that is that we have several scenarios to be handled like
[field]
,@=field
,"@=resolver("Page", [field, context])"
etc. where currentstr_replace
needs to be invoked.