Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-772: Fixes bad link to composer auth var setup #11

Merged
merged 1 commit into from
Jul 15, 2021
Merged

IBX-772: Fixes bad link to composer auth var setup #11

merged 1 commit into from
Jul 15, 2021

Conversation

crevillo
Copy link
Contributor

@crevillo crevillo commented Jul 14, 2021 •
edited by adamwojs
Loading

Question Answer
JIRA issue IBX-772
Type bug
Target Ibexa version v4.0
BC breaks no

There is a deadline in the comment of platform.app.yaml generated for ibexa commerce. I checked the others and it seems there are fine.

ping @ibexa/engineering

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@adamwojs adamwojs requested review from webhdx and a team July 14, 2021 15:32
@adamwojs adamwojs added the Bug Something isn't working label Jul 14, 2021
@lserwatka
Copy link

Is 1.0 brach affected as well?

@crevillo
Copy link
Contributor Author

crevillo commented Jul 14, 2021 •
edited
Loading

sorry, I didn't check that. Yes, looks affected as well. Should I change the pull request to merge into that branch?

@lserwatka
Copy link

Yes, please. Just change target branch to 1.0.

@crevillo crevillo changed the base branch from main to 1.0 July 14, 2021 20:20
@crevillo crevillo force-pushed the IBX-772-fix-bad-link-in-comment branch from fd742b5 to 994c4f3 Compare July 14, 2021 20:25
@crevillo
Copy link
Contributor Author

Target branch changed. Still we may need another commit to master to fix the 4.x .platform.app.yaml which is not present in the 1.0 branch.

@adamwojs adamwojs merged commit 303bfca into ibexa:1.0 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webhdx webhdx webhdx approved these changes

@damianz5 damianz5 damianz5 approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crevillo @lserwatka @adamwojs @Steveb-p @damianz5 @webhdx