IBX-7361: The search criterion is searching for all text fields of contents #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
reviewed
Dec 21, 2023
src/lib/EventDispatcher/EventListener/ContentSuggestionSubscriber.php
Outdated
Show resolved
Hide resolved
tests/lib/EventDispatcher/EventListener/ContentSuggestionSubscriberTest.php
Outdated
Show resolved
Hide resolved
tests/lib/EventDispatcher/EventListener/ContentSuggestionSubscriberTest.php
Outdated
Show resolved
Hide resolved
tests/lib/EventDispatcher/EventListener/ContentSuggestionSubscriberTest.php
Outdated
Show resolved
Hide resolved
mikadamczyk
reviewed
Dec 21, 2023
tests/lib/EventDispatcher/EventListener/ContentSuggestionSubscriberTest.php
Outdated
Show resolved
Hide resolved
tests/lib/EventDispatcher/EventListener/ContentSuggestionSubscriberTest.php
Outdated
Show resolved
Hide resolved
tests/lib/EventDispatcher/EventListener/ContentSuggestionSubscriberTest.php
Outdated
Show resolved
Hide resolved
tests/lib/EventDispatcher/EventListener/ContentSuggestionSubscriberTest.php
Outdated
Show resolved
Hide resolved
mikadamczyk
approved these changes
Dec 22, 2023
Steveb-p
approved these changes
Dec 28, 2023
Comment on lines
+118
to
+120
| $this->loggerMock | ||
| ->expects($this->once()) | ||
| ->method('error'); |
There was a problem hiding this comment.
What will be the message?
Suggested change
| $this->loggerMock | |
| ->expects($this->once()) | |
| ->method('error'); | |
| $this->loggerMock | |
| ->expects(self::once()) | |
| ->method('error') | |
| ->with(...); |
Will the exception, if any, be logged into it?
| $subscriber = new ContentSuggestionSubscriber($searchService, $mapper); | ||
| $sortingDefinitionRegistry = $this->getSortingDefinitionRegistryMock(); | ||
|
|
||
| $subscriber = new ContentSuggestionSubscriber($searchService, $mapper, $sortingDefinitionRegistry); |
There was a problem hiding this comment.
You can, although it is slightly out of scope as it enhances the existing test, make assertions about logger not being called (self::never()).
| private bool $searchServiceSupportsScoring = false; | ||
|
|
||
| /** @var \Psr\Log\LoggerInterface&\PHPUnit\Framework\MockObject\MockObject */ | ||
| private LoggerInterface $loggerMock; |
There was a problem hiding this comment.
In my opinion, since logger is never configured during setUp or used across different methods, it should be kept as a local variable.
But it's only an opinion and feel free to discard it.
This was referenced Jan 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes sorting issues
Checklist:
$ composer fix-cs)