Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7462: Removed "Top Level Nodes" from breadcrumbs in search suggestions #42

Merged
merged 1 commit into from
Apr 25, 2024
Merged

IBX-7462: Removed "Top Level Nodes" from breadcrumbs in search suggestions #42

merged 1 commit into from
Apr 25, 2024

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Dec 25, 2023 •
edited by Steveb-p
Loading

Question Answer
Tickets IBX-7462
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

image

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs requested a review from a team January 3, 2024 09:48
@konradoboza konradoboza requested a review from a team January 4, 2024 08:53
@adamwojs adamwojs changed the base branch from main to 4.6 April 21, 2024 08:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs requested review from webhdx and a team April 21, 2024 09:50
@Steveb-p Steveb-p changed the title IBX-7462: Removed "Top Level Nodes" from breadcrumbs in search sugges… IBX-7462: Removed "Top Level Nodes" from breadcrumbs in search suggestions Apr 22, 2024
Steveb-p
Steveb-p approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@bogusez bogusez self-assigned this Apr 25, 2024
This was referenced Apr 25, 2024
Closed
Closed
Closed
@bogusez
Copy link

bogusez commented Apr 25, 2024

Tested on Legacy, ES and Solr search engines

@adamwojs adamwojs merged commit 524490c into 4.6 Apr 25, 2024
12 checks passed
@adamwojs adamwojs deleted the ibx_7462 branch April 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisztof kisztof kisztof requested changes

@bogusez bogusez bogusez approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@kisztof kisztof

@tischsoic tischsoic

@ViniTou ViniTou

@bogusez bogusez

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adamwojs @bogusez @kisztof @Steveb-p @webhdx @ViniTou @konradoboza @tischsoic