-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2977: Added API for invitation refreshing #42
Conversation
@@ -20,6 +20,7 @@ | |||
<php> | |||
<env name="KERNEL_CLASS" value="Ibexa\Tests\Integration\User\IbexaTestKernel" /> | |||
<env name="DATABASE_URL" value="sqlite://i@i/test.db" /> | |||
<env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK (61 tests, 90 assertions)
Remaining self deprecation notices (13)
<env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/> | |
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=14&verbose=0" /> |
Should ensure that new direct deprecations are not added in subsequent PR's.
As a side note, current deprecations can be saved into a baseline file following https://symfony.com/doc/current/components/phpunit_bridge.html#baseline-deprecations instructions. This would ensure that adding new direct deprecations is forbidden with exact specificity, i.e. you would not be able to remove & add different deprecations (as it's not based on deprecation count).
But from my perspective a deprecation count would be more than enough. Current deprecations are easily fixable and rather important when going for Symfony 6.
b96c739
to
2543722
Compare
Needs to be rebased after
#41
is merged
Relevant commits:
a40c8e1
fc3964c
Checklist:
$ composer fix-cs
)