Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2977: Added API for invitation refreshing #42

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jun 3, 2022

Question Answer
Tickets IBX-2977
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Needs to be rebased after
#41
is merged

Relevant commits:
a40c8e1
fc3964c

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@ViniTou ViniTou added Doc needed The changes require some documentation Rebase required labels Jun 3, 2022
@ViniTou ViniTou requested a review from a team June 3, 2022 14:19
@Nattfarinn Nattfarinn requested a review from a team June 14, 2022 08:17
@alongosz alongosz requested a review from a team June 15, 2022 09:45
composer.json Outdated Show resolved Hide resolved
phpunit.xml Show resolved Hide resolved
@ViniTou ViniTou requested a review from Steveb-p June 20, 2022 07:40
@ViniTou ViniTou changed the base branch from main to ibx-2975-find-invitations June 20, 2022 07:42
@@ -20,6 +20,7 @@
<php>
<env name="KERNEL_CLASS" value="Ibexa\Tests\Integration\User\IbexaTestKernel" />
<env name="DATABASE_URL" value="sqlite://i@i/test.db" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK (61 tests, 90 assertions)
Remaining self deprecation notices (13)
Suggested change
<env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=14&amp;verbose=0" />

Should ensure that new direct deprecations are not added in subsequent PR's.

As a side note, current deprecations can be saved into a baseline file following https://symfony.com/doc/current/components/phpunit_bridge.html#baseline-deprecations instructions. This would ensure that adding new direct deprecations is forbidden with exact specificity, i.e. you would not be able to remove & add different deprecations (as it's not based on deprecation count).

But from my perspective a deprecation count would be more than enough. Current deprecations are easily fixable and rather important when going for Symfony 6.

Base automatically changed from ibx-2975-find-invitations to main June 23, 2022 14:48
@ViniTou ViniTou force-pushed the ibx-2977-refresh-invitations branch from b96c739 to 2543722 Compare June 23, 2022 14:54
@ViniTou ViniTou merged commit 116cecd into main Jun 23, 2022
@ViniTou ViniTou deleted the ibx-2977-refresh-invitations branch June 23, 2022 14:58
@MagdalenaZuba MagdalenaZuba removed the Doc needed The changes require some documentation label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants