Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(steps): add transform for polynomial features #53

Merged
merged 8 commits into from
Apr 16, 2024
Merged

feat(steps): add transform for polynomial features #53

merged 8 commits into from
Apr 16, 2024

Conversation

jitingxu1
Copy link
Collaborator

Add polynomial features

Resolve #41

@jitingxu1 jitingxu1 requested a review from deepyaman April 3, 2024 21:50
@jitingxu1 jitingxu1 mentioned this pull request Apr 3, 2024
1 task
ibisml/steps/feature_engineering.py Outdated Show resolved Hide resolved
ibisml/steps/feature_engineering.py Outdated Show resolved Hide resolved
ibisml/steps/feature_engineering.py Outdated Show resolved Hide resolved
ibisml/steps/feature_engineering.py Outdated Show resolved Hide resolved
tests/test_feature_engineering.py Outdated Show resolved Hide resolved
@jitingxu1
Copy link
Collaborator Author

@deepyaman resolved the issues, please take another look whenever you have time.

Copy link
Collaborator

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, few more small requests...

ibisml/steps/feature_engineering.py Outdated Show resolved Hide resolved
tests/test_feature_engineering.py Outdated Show resolved Hide resolved
tests/test_feature_engineering.py Outdated Show resolved Hide resolved
ibisml/steps/feature_engineering.py Outdated Show resolved Hide resolved
ibisml/steps/feature_engineering.py Outdated Show resolved Hide resolved
@deepyaman deepyaman changed the title feat: polynomial features feat(steps): add transform for polynomial features Apr 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@3e64906). Click here to learn what that means.

Files Patch % Lines
ibisml/steps/feature_engineering.py 88.23% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage        ?   81.05%           
=======================================
  Files           ?       19           
  Lines           ?     1362           
  Branches        ?        0           
=======================================
  Hits            ?     1104           
  Misses          ?      258           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with all the changes! :shipit:

@deepyaman deepyaman merged commit 1c434c3 into ibis-project:main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

feat: Polynomial features transformation
3 participants