[MapD] Resolves Joining with different column names #1647

xmnlab · 2018-10-02T23:47:14Z

cpcloud · 2018-10-04T15:27:06Z

ibis/mapd/operations.py

@@ -596,6 +596,7 @@ class ByteLength(ops.StringLength):
 # GENERAL
 _general_ops = {
    ops.Literal: literal,
+    ops.NullLiteral: lambda *args: 'CAST(NULL AS FLOAT)',


I don't think this is the correct fix for this. We need to cast to the correct type wherever NULL is being used. In the case of #1620, it's in the code that the bucket method is generating.

I see ... could you provide more example or explanation about that? I am not sure how to get the type if I just use ibis.literal(None)

cpcloud · 2018-10-07T20:33:07Z

@xmnlab I will fix the null type issue in a different PR. Basically, we need to cast the null in the case statement to the results type so that there isn't an untyped null hanging around.

xmnlab · 2018-10-08T14:16:03Z

@cpcloud thank you so much! If you can ping me in the PR, please ... I really want to learn how to do this :)
I will remove the literal null changes in this PR.

codecov · 2018-10-12T00:50:45Z

Codecov Report

Merging #1647 into master will decrease coverage by 2.66%.
The diff coverage is 84%.

@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
- Coverage   90.01%   87.35%   -2.67%     
==========================================
  Files         185      185              
  Lines       27283    27223      -60     
  Branches     2329     2338       +9     
==========================================
- Hits        24559    23780     -779     
- Misses       2323     3036     +713     
- Partials      401      407       +6

Impacted Files	Coverage Δ
ibis/mapd/tests/test_operations.py	`95.45% <100%> (-0.98%)`	⬇️
ibis/mapd/tests/conftest.py	`61.7% <100%> (+3.56%)`	⬆️
ibis/mapd/compiler.py	`81.88% <71.42%> (+2.21%)`	⬆️
ibis/bigquery/tests/test_client.py	`25.87% <0%> (-73.55%)`	⬇️
ibis/bigquery/tests/test_compiler.py	`39.89% <0%> (-60.11%)`	⬇️
ibis/bigquery/udf/tests/test_udf_execute.py	`28% <0%> (-54.18%)`	⬇️
ibis/bigquery/client.py	`42.91% <0%> (-52.37%)`	⬇️
ibis/bigquery/compiler.py	`58.82% <0%> (-38.61%)`	⬇️
ibis/bigquery/tests/conftest.py	`70.27% <0%> (-16.22%)`	⬇️
ibis/bigquery/udf/api.py	`80.48% <0%> (-14.64%)`	⬇️
... and 34 more

cpcloud · 2018-10-20T16:36:05Z

@xmnlab Can you add a test for this?

cpcloud · 2018-10-20T18:11:01Z

@xmnlab Can you rebase and push all of your PRs?

…into add_literal_null

xmnlab · 2018-10-23T01:31:17Z

@cpcloud sure! I am working on that! thanks!

xmnlab · 2018-10-23T02:41:11Z

it raised a error for maiadb installation on windows+py36

ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://downloads.mariadb.org/f/mariadb-10.2.14/winx64-packages/mariadb-10.2.14-winx64.msi'. Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (403) Forbidden."
2018-10-23T02:19:58.6711299Z The install of mariadb was NOT successful.

xmnlab · 2018-10-25T17:00:51Z

azure pipelines is still raising error on windows_test py35 for mariadb:

2018-10-25T16:51:17.8292526Z Downloading mariadb 64 bit
2018-10-25T16:51:17.8293327Z   from 'https://downloads.mariadb.org/f/mariadb-10.2.14/winx64-packages/mariadb-10.2.14-winx64.msi'
2018-10-25T16:51:20.3065302Z ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://downloads.mariadb.org/f/mariadb-10.2.14/winx64-packages/mariadb-10.2.14-winx64.msi'. Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (403) Forbidden."
2018-10-25T16:51:20.6532187Z The install of mariadb was NOT successful.
2018-10-25T16:51:20.6551619Z Error while running 'C:\ProgramData\chocolatey\lib\mariadb\tools\chocolateyInstall.ps1'.
2018-10-25T16:51:20.6551954Z  See log for details.
2018-10-25T16:51:22.7495596Z 
2018-10-25T16:51:22.7496068Z Chocolatey installed 0/1 packages. 1 packages failed.
2018-10-25T16:51:22.7496140Z  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2018-10-25T16:51:22.7505864Z 
2018-10-25T16:51:22.7511324Z Failures
2018-10-25T16:51:22.7518311Z  - mariadb (exited 404) - Error while running 'C:\ProgramData\chocolatey\lib\mariadb\tools\chocolateyInstall.ps1'.
2018-10-25T16:51:22.7518456Z  See log for details.
2018-10-25T16:51:23.5270254Z ##[error]Cmd.exe exited with code '404'.

cpcloud · 2018-10-26T21:24:39Z

@xmnlab Can you rebase your PRs again? The failing builds should be fixed as of #1667 (among other things a new version of flake8 caused some failed linting). I will review your PRs in the meantime.

xmnlab · 2018-10-27T14:24:26Z

thanks @cpcloud! rebased!

cpcloud · 2018-10-28T14:19:09Z

@xmnlab can your resolve the merge conflicts? i will merge after that.

xmnlab · 2018-10-29T01:57:24Z

rebased! thanks @cpcloud !

xmnlab added 2 commits October 2, 2018 17:10

Solves ibis-project#1620: Added NullLiteral

e136257

Fixed ibis-project#1619: Joining on different column names

4c4d995

cpcloud reviewed Oct 4, 2018

View reviewed changes

xmnlab added 2 commits October 11, 2018 20:48

Merge remote-tracking branch 'ibis-project/master' into add_literal_null

31c186e

NullLiteral moved again as unsupported

4d36a15

xmnlab changed the title ~~[MapD] Resolves Literal Null and Joining on different column names~~ [MapD] Resolves Joining with different column names Oct 12, 2018

xmnlab added 2 commits October 15, 2018 00:04

Merge branch 'upstream_master' into add_literal_null

7374d82

Merge branch 'master' into add_literal_null

eaa523e

cpcloud added mapd bug Incorrect behavior inside of ibis labels Oct 20, 2018

cpcloud added this to the Next Release milestone Oct 20, 2018

xmnlab added 2 commits October 22, 2018 21:04

Merge branch 'upstream_master' into add_literal_null

155ed0a

Merge branch 'add_literal_null' of https://github.com/quansight/ibis …

fc9e029

…into add_literal_null

Added tests

e7c70c3

Fixed tests

180ea2f

Merged from master

b8e441f

cpcloud approved these changes Oct 28, 2018

View reviewed changes

Merge from master

86fda52

cpcloud closed this in afe35e1 Oct 30, 2018

xmnlab deleted the add_literal_null branch March 27, 2019 01:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MapD] Resolves Joining with different column names #1647

[MapD] Resolves Joining with different column names #1647

xmnlab commented Oct 2, 2018 •

edited

Loading

cpcloud Oct 4, 2018

xmnlab Oct 4, 2018

cpcloud commented Oct 7, 2018

xmnlab commented Oct 8, 2018

codecov bot commented Oct 12, 2018 •

edited

Loading

cpcloud commented Oct 20, 2018

cpcloud commented Oct 20, 2018

xmnlab commented Oct 23, 2018

xmnlab commented Oct 23, 2018

xmnlab commented Oct 25, 2018

cpcloud commented Oct 26, 2018

xmnlab commented Oct 27, 2018

cpcloud commented Oct 28, 2018

xmnlab commented Oct 29, 2018

[MapD] Resolves Joining with different column names #1647

[MapD] Resolves Joining with different column names #1647

Conversation

xmnlab commented Oct 2, 2018 • edited Loading

cpcloud Oct 4, 2018

Choose a reason for hiding this comment

xmnlab Oct 4, 2018

Choose a reason for hiding this comment

cpcloud commented Oct 7, 2018

xmnlab commented Oct 8, 2018

codecov bot commented Oct 12, 2018 • edited Loading

Codecov Report

cpcloud commented Oct 20, 2018

cpcloud commented Oct 20, 2018

xmnlab commented Oct 23, 2018

xmnlab commented Oct 23, 2018

xmnlab commented Oct 25, 2018

cpcloud commented Oct 26, 2018

xmnlab commented Oct 27, 2018

cpcloud commented Oct 28, 2018

xmnlab commented Oct 29, 2018

xmnlab commented Oct 2, 2018 •

edited

Loading

codecov bot commented Oct 12, 2018 •

edited

Loading