-
Notifications
You must be signed in to change notification settings - Fork 586
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapD bucket() : MapD backend doesn't support <class 'ibis.expr.operations.NullLiteral'> operation! #1620
Comments
cc @xmnlab |
@randyzwitch it seems MapD doesn't allow Null literal, is it right? ex:
|
That seems right @xmnlab, I've never seen a query try to do that :) |
@cpcloud so this error is expected? should we add some operations in MapD |
This isn't totally crazy and isn't very different from something like |
I can't comment on whether we'd ever support But, I'm not one of the OmniSci backend engineers either :) |
Often a database will require a cast when using a null literal. |
If it's the case that this is really a desirable operation, my suggestion would be to submit an issue and someone with the proper background (either product or engineering) can comment on the specifics: |
done! heavyai/heavydb#269 :) |
@cpcloud should we change anything in the code related to this issue? or could this issue be closed? |
@xmnlab If you write |
awesome! very good idea!
|
@xmnlab Can you dig into what the generated code here is and see if it's reasonable to cast? I suspect that it is. |
sure! I am working on that :) |
Fixes #1619 Author: Ivan Ogasawara <ivan.ogasawara@gmail.com> Author: Ivan <ivan.ogasawara@gmail.com> Closes #1647 from xmnlab/add_literal_null and squashes the following commits: 86fda52 [Ivan Ogasawara] Merge from master b8e441f [Ivan Ogasawara] Merged from master 180ea2f [Ivan Ogasawara] Fixed tests e7c70c3 [Ivan Ogasawara] Added tests fc9e029 [Ivan Ogasawara] Merge branch 'add_literal_null' of https://github.com/quansight/ibis into add_literal_null 155ed0a [Ivan Ogasawara] Merge branch 'upstream_master' into add_literal_null eaa523e [Ivan] Merge branch 'master' into add_literal_null 7374d82 [Ivan Ogasawara] Merge branch 'upstream_master' into add_literal_null 4d36a15 [Ivan Ogasawara] NullLiteral moved again as unsupported 31c186e [Ivan Ogasawara] Merge remote-tracking branch 'ibis-project/master' into add_literal_null 4c4d995 [Ivan Ogasawara] Fixed #1619: Joining on different column names e136257 [Ivan Ogasawara] Solves #1620: Added NullLiteral
>>> buckets = [0, 1, 3]
>>> bucketed = table.price_col.bucket(buckets).name('bucket')
>>> bucketed.value_counts().execute()
return error :
File "/home/sw/anaconda3/lib/python3.6/site-packages/ibis/mapd/operations.py", line 365, in raise_unsupported_op_error
raise com.UnsupportedOperationError(msg.format(type(op)))
ibis.common.UnsupportedOperationError: MapD backend doesn't support <class 'ibis.expr.operations.NullLiteral'> operation!
Backend=MapD MapD=4.1.1 ibis=0.14 Python=3.6
Ubuntu=18.04 Anaconda=5.1
The text was updated successfully, but these errors were encountered: