Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opengraph): add opengraph support for posts #149

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Conversation

cubesky
Copy link
Collaborator

@cubesky cubesky commented Jan 17, 2017

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

No verification steps.

@ghost
Copy link

ghost commented Jan 17, 2017

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request description must include verification steps (?)
  • Pull request title must start with uppercase (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@cubesky cubesky changed the title feat(opengraph): add opengraph support for posts Feat(opengraph): add opengraph support for posts Jan 17, 2017
@ghost
Copy link

ghost commented Jan 17, 2017

This pull request still violates some of our guidelines:

  • Pull request description must include verification steps (?)

Click here for details.

@cubesky cubesky changed the title Feat(opengraph): add opengraph support for posts feat(opengraph): Add opengraph support for posts Jan 17, 2017
@ghost
Copy link

ghost commented Jan 17, 2017

This pull request still violates some of our guidelines:

  • Pull request description must include verification steps (?)
  • Pull request title must start with uppercase (?)

Click here for details.

@cubesky cubesky changed the title feat(opengraph): Add opengraph support for posts Feat(opengraph): Add opengraph support for posts Jan 17, 2017
@ghost
Copy link

ghost commented Jan 17, 2017

This pull request still violates some of our guidelines:

  • Pull request description must include verification steps (?)

Click here for details.

@ghost
Copy link

ghost commented Jan 17, 2017

Thank you, the title and description now looks good! :bowtie:

@neoFelhz neoFelhz changed the title Feat(opengraph): Add opengraph support for posts feat(opengraph): Add opengraph support for posts Jan 17, 2017
@ghost
Copy link

ghost commented Jan 17, 2017

This pull request still violates some of our guidelines:

  • Pull request title must start with uppercase (?)

Click here for details.

@ghost
Copy link

ghost commented Jan 17, 2017

Thank you, the title and description now looks good! :bowtie:

@neoFelhz neoFelhz merged commit 5631b78 into canary Jan 17, 2017
@neoFelhz neoFelhz deleted the feat/opengraph branch January 17, 2017 15:26
@iblh iblh changed the title feat(opengraph): Add opengraph support for posts feat(opengraph): add opengraph support for posts Jan 28, 2017
@iblh iblh mentioned this pull request Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants