Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove(layout): remove private layout #310

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Conversation

neoFelhz
Copy link
Collaborator

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

If you don't do so, we might change your pull request's title and using squash to merge your changed.

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

Remove the useless private layout.


Verification steps

No verification steps.

@neoFelhz neoFelhz requested review from cubesky and iblh April 21, 2017 10:40
@kmahyyg
Copy link

kmahyyg commented Apr 21, 2017

@neoFelhz plz don't remove it.it's really useful if I want to share some private thing to my friend.

@neoFelhz
Copy link
Collaborator Author

neoFelhz commented Apr 21, 2017

@kmahyyg
If you had read the source code of the private layout, you will find how dirty the layout is: simply loading a tips instead of the post content.
I suggest you using hexo-blog-encrypt plugin. It's better than that.

@neoFelhz neoFelhz merged commit 32c922f into canary Apr 21, 2017
@neoFelhz neoFelhz deleted the remove/layout/private branch April 21, 2017 13:47
@kmahyyg
Copy link

kmahyyg commented Apr 21, 2017

@neoFelhz ok ,that's nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants