Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(font): fonts customization. #330

Merged
merged 2 commits into from
Apr 29, 2017
Merged

feat(font): fonts customization. #330

merged 2 commits into from
Apr 29, 2017

Conversation

neoFelhz
Copy link
Collaborator

@neoFelhz neoFelhz commented Apr 29, 2017

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

If you don't do so, we might change your pull request's title and using squash to merge your changed.

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

Load the font from cdn.

  • When using google, theme will load Roboto & Material Icon from fonts.googleapi.com, while Font-Awesome will load from MaterialCDN or local.
  • When using baomitu, all the fonts will load from cdn.baomitu.com.

All of them are SSL supported. And cdn.baomitu.com is with HTTP/2 enabled while font.googleapi.com is with h2+quic 37 enabled.

I change the font-family settings variable as well, which may cause BREAKING CHANGES.


Verification steps

No verification steps.

@neoFelhz neoFelhz requested review from cubesky and iblh April 29, 2017 09:27
@neoFelhz neoFelhz merged commit 9c92e15 into canary Apr 29, 2017
@neoFelhz neoFelhz deleted the feat/fonts branch April 29, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants