Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test file and IntlShim #13

Merged
merged 2 commits into from
Apr 15, 2014
Merged

Fix test file and IntlShim #13

merged 2 commits into from
Apr 15, 2014

Conversation

wkeese
Copy link
Member

@wkeese wkeese commented Apr 15, 2014

  1. quick fix to make IntlShim.js work on browsers other than Chrome. As I mentioned before, it should really use has!
  2. fix test file in various ways, including not claiming that your code's output is "native"

Explicitly loading Intl defeats the purpose of IntlShim.
Also, fix path to requirejs.
@wkeese wkeese mentioned this pull request Apr 15, 2014
@ashensis
Copy link

I am out of the office until 22/04/2014.

I will respond to your message when I return after Jewish Passower
Holidays,

Note: This is an automated response to your message "[ecma402] Fix test
file and IntlShim (#13)" sent on 15/04/2014 6:16:53.

This is the only notification you will receive while this person is away.

@wajnberg
Copy link

I am out of the office until 04/23/2014.

I will respond to your message when I return.
For emergency cases you can contact me on
00 972 58 778 8079

Note: This is an automated response to your message "[ecma402] Fix test
file and IntlShim (#13)" sent on 15/04/2014 6:16:53.

This is the only notification you will receive while this person is away.

JCEmmons added a commit that referenced this pull request Apr 15, 2014
@JCEmmons JCEmmons merged commit bf553de into ibm-js:master Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants