Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the version of witherspoon-pfault-analysis for mowgli & fix mowgli's psu issue #134

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Update the version of witherspoon-pfault-analysis for mowgli & fix mowgli's psu issue #134

merged 2 commits into from
Jan 4, 2021

Conversation

AndyYFWang
Copy link

  1. Update the version of witherspoon-pfault-analysis for mowgli.
    Update the version of witherspoon-pfault-analysis for being used by mowgli.

  2. Fix mowgli's psu reading fail issue.
    Due to mowgli's psu(Artesyn) doesn't support PMBus PEC checking,
    thermal reading and linear-16-conversion-formula, need to remove
    them by updating driver patch for fixing psu reading error.

Signed-off-by: Andy YF Wang Andy_YF_Wang@wistron.com

AndyYFWang added 2 commits December 23, 2020 16:22
Update the version of witherspoon-pfault-analysis
d353fb0 
Update the version of witherspoon-pfault-analysis for mowgli.

Signed-off-by: Andy YF Wang <Andy_YF_Wang@wistron.com>
Fix mowgli's psu reading fail issue
473f953 
Due to mowgli's psu(Artesyn) doesn't support PMBus PEC checking,
thermal reading and linear-16-conversion- formula, need to remove
them by updating driver patch for fixing psu reading error.

Signed-off-by: Andy YF Wang <Andy_YF_Wang@wistron.com>
@AndyYFWang AndyYFWang changed the title Op940 20201223 1 Fix mowgli's psu issue & update the version of witherspoon-pfault-analysis for mowgli Dec 24, 2020
@AndyYFWang AndyYFWang changed the title Fix mowgli's psu issue & update the version of witherspoon-pfault-analysis for mowgli Update the version of witherspoon-pfault-analysis for mowgli & fix mowgli's psu issue Dec 24, 2020
geissonator
geissonator reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@geissonator geissonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some more info on this kernel patch? Can it be sent upstream?

@AndyYFWang
Copy link
Author

Hi Andrew,

The FW version of the PSU used by Mowgli is too old, so it doesn't fully support the latest PMBus specifications, such as PEC checking, linear16-conversion-formula (for Vout reading) and some thermal reading functions are not supported.
But the PMbus kernel code currently used by OP940 supports the above functions (https://github.com/openbmc/linux/blob/v5.4.62/drivers/hwmon/pmbus/pmbus_core.c), so I need to use this kernel patch to ignore these unsupported functions to make the psu can be read sucessfully.

@geissonator
Copy link
Contributor

Hi Andrew,

The FW version of the PSU used by Mowgli is too old, so it doesn't fully support the latest PMBus specifications, such as PEC checking, linear16-conversion-formula (for Vout reading) and some thermal reading functions are not supported.
But the PMbus kernel code currently used by OP940 supports the above functions (https://github.com/openbmc/linux/blob/v5.4.62/drivers/hwmon/pmbus/pmbus_core.c), so I need to use this kernel patch to ignore these unsupported functions to make the psu can be read sucessfully.

ok, it would be ideal to have the driver support your PSU version, so patches like this are not needed. But, it's your system and you will be responsible for supporting it if we bring in future kernel versions that are not compatible with your patch so it's your decision.

@rfrandse rfrandse merged commit ef7ce3b into ibm-openbmc:OP940 Jan 4, 2021
@BenPai99 BenPai99 deleted the op940_20201223-1 branch January 8, 2021 02:07
rfrandse added a commit that referenced this pull request Apr 29, 2022
@rfrandse
pldm: downstream srcrev bump 0287a826f2..7939ba4b83 (#1874)
28619fb 
Pavithrab7 (2):
  fix the fru record table (#134)
  Change BIOS attribute default value (#135)

Change-Id: Ic9d056ea7e5ca5f323bca1e59cd5ab1b9f50d0ef
rfrandse pushed a commit that referenced this pull request Mar 28, 2024
@anoo1 @rfrandse
openpower-vpd-parser: downstream srcrev bump c1d37f9df3..f7a38ddbdb
dd0bc2b 
Jinu Joy Thomas (5):
  Update service files in repo (#133)
  fix GCC 13 issues (#134)
  Merge pull request #136 from jinuthomas/1050
  Merge pull request #138 from PriyangaRamasamy/vpd-tool-skip-Asset
  Merge pull request #137 from GiridhariKrishnan/1050

girik (1):
  DIMM capacity changed from MB to KB

Priyanga Ramasamy (1):
  vpd-tool:Skip displaying Asset interface

jinuthomas (1):
  Catching File Exceptions in openpower-vpd-parser

Change-Id: I83fafe44747468667dc78da0a12800c491f71a6d
rfrandse added a commit that referenced this pull request Mar 28, 2024
@rfrandse
phosphor-debug-collector: downstream srcrev bump 9344945852..5ac040fd…
5e5c60f 
…f3 (#4243)

Andrew Geissler (1):
  Modify plugin to capture all journal data during elog/core dump (#134)

Change-Id: Iea8395ae61d0875360b4b13216d4037c7b074243
rfrandse added a commit that referenced this pull request Mar 28, 2024
@rfrandse
webui-vue: public downstream srcrev bump 203a27a3dc..2a6a5f299a
dc0ced6 
George Liu (1):
  Fix server firmware start policy (#77)

Steffi Antony (11):
  Disabled search and filter option in PCIe topology (#164)
  Toggle button moving twice (#169)
  Enablement TCE Table Pre-Allocation for Dynamic Drawer Add (#181)
  Updated Status in Inventory and LEDs page (#190)
  Updated Status in Inventory and LEDs page (#191)
  Added an additional message for hostname (#185)
  Handled DHCP network configurations (#193)
  Updated validation for Bonnell system (#199)
  Handled 2 post request CSR generation (#200)
  Updated availability info on IBMi service functions page (#202)
  Disabled Power cap fields (#203)

Nabil Ananthamangalath (3):
  Implemented Redfish message ID checks using Regex (#170)
  Implemented SRC details in Progress Logs page (#178)
  Fixed improperly formatted CSR data (#192)

sandeepasingh116 (8):
  Fix login page logo issue (#81)
  Fix network page modal issue (#76)
  Fix network page toast msg bug (#78)
  Add warning message to date time page (#80)
  Fix logo issue (#82)
  Add IPv6 table (#85)
  Fix the ipv6 address validator regex (#88)
  Add 1LA settings (#93)

Gunnar Mills (4):
  Fix popup-box authenticate on session disconnect (#106)
  Bump the Notice Text to 1050 (#113)
  Move webui-vue to use Context (#120)
  Match PLDM: correct Gard to Guard (#158)

Nikhil Ashoka (54):
  Labels now updating in Concurrent maintenance page (#63)
  Refresh only once and title translation (#65)
  Pagination fixed in Dumps (#64)
  Fixed Remote port location (#79)
  Fabric Adapters showing right info in the respective tabs (#75)
  Checking IP address and filtering (#83)
  Fixed Health and Status values for I/O expansion chassis (#91)
  VET Capabilties names updated (#92)
  Performance improved for Sensors page (#89)
  Logging out after hostname update (#94)
  Performance improved for Pcie-topology page (#87)
  "Secure LDAP" value is retained (#96)
  Toast message added to Power supplies LEDs (#97)
  Changed the default value of Health in Inventory page (#95)
  Resource dump is now submitted in any state (#99)
  Dumps initiate fixed (#101)
  Informational logs not shown for the admin (#102)
  Delay to retrieve data when new address is added (#103)
  Updated the helptext of RTAD (#100)
  Filter values for Sensors and PCIe topology taken from translation file (#108)
  1LA: Runtime Processor Diagnostics Updated (#112)
  Fixed Download Event Logs and Informational Logs (#115)
  Fixed PCIe Slots reload issue on toggle (#117)
  Added toast messages for Immediate test requests and Scheduled (#119)
  Updated the payload for ACF certificates (#121)
  Added toast message for LEDs in PCIe topology (#126)
  Updated toast message for System attention LED (#129)
  Added delay in getting the tables in Network page (#124)
  Added delay to get the updated NTP date and time (#132)
  Updated delete ACF certificate request body (#135)
  Implemented IPv6 static default gateways (#141)
  Removed Alert and added info icons in system parameters page (#137)
  Implemented new logic for I/O slots (#138)
  Filtering out System Anchor from VET capabilities (#144)
  Filtering the IP address in HMC and user sessions (#146)
  Parent Link ID new GUI logic (#145)
  Added delay to get the updated SLAAC address (#150)
  Able to change expired password (#152)
  Detailed error message for Resource Dump if system not PHYP in stndby (#151)
  Adding delay to Delete and disabling tables (#155)
  Linux KVM implementation (#157)
  Load Navigation Items after checking model type (#160)
  Added HMC managed check for System Memory Reserved for KVM Guest Management (#162)
  Updated Linux KVM implementation (#168)
  Disabled AMM for Bonnell (#166)
  Updated Upstream fabric adapters in PCIe topology (#172)
  Updated System Memory Reserved for KVM Guest Management (#173)
  Implement IBM i Service Functions (#161)
  Fixed translation file issue (#183)
  - Renamed "IBM i alternate load source" to "IBM i alternate restart device" (#189)
  1KW: Network settings implementation (#186)
  Added Info tooltip in Inventory and LEDs (#205)
  Upgraded the Axios verison (#206)
  Removed default Alert message (#208)

vedangimittal (6):
  Disabled horizontal scroll on Notices page (#165)
  Removed expand option under PCIe slots (#171)
  “Service Login Certificate” updated using translation file (#182)
  Frequency cap value validation (#188)
  Updated select dump type tool tip  message (#198)
  Updated the IBM i options description (#201)

Renuka9527 (27):
  Fixed User unable to delete the firmware file if name is long on firmware page (#107)
  Fixed search functionality for all the fields in Inventory and LED page (#109)
  Fixed success toast in inventory led's (#111)
  Added condition check for the Expired access key error and fetching from translations (#105)
  Fixed operations menu items when opened in anothersession (#110)
  Fixed deconfiguration record header (#104)
  Added a confirm box on enabling the Unauthenticated ACF upload enablement (#116)
  Fixed success message on delete all error logs operation (#118)
  Fixed hypervisor console when power is off to disconnected (#123)
  updated HMC and user sessions warning message (#128)
  Fixed error message for read only use password change (#130)
  Fixed error message expired access key (#131)
  Removed privilege change option for read only users (#133)
  Added Success Toast with reload message for HTTP certificate (#134)
  Added 30 secs delay for Updating Network IPMI (out-of-band IPMI) protocol (#127)
  Updated Privilege options in User Management page (#140)
  Added condition check for manual and normal modes for displaying prompt (#142)
  disabled the server power options on save and enabling on succesfull save (#148)
  Removed pel id and replaced with event id (#154)
  Added latest notices file (#156)
  Blinking issue of health button while clicking on Event Logs submenu form other menus. (#153)
  Added condition check for the system operating mode (#179)
  reverted the translation change from store and added to table row with certificate check (#184)
  Audit Logs Page Implementation (#174)
  Disabled the selection till save is success for bios setting (#180)
  Removed Downloading the Empty Audit log files when download API is failing from GUI. (#195)
  Added LocationIndicatorActive check in Inventory page (#187)

Change-Id: If69ae53bc29eaadebcd09291e45c0d27fb7f9e29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geissonator geissonator geissonator approved these changes

@spinler spinler spinler approved these changes

@eddiejames eddiejames Awaiting requested review from eddiejames

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndyYFWang @geissonator @spinler @rfrandse