Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset: Add SubModel #15

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

LuluTHSu
Copy link

SubModel is used to identify network interface.

Signed-off-by: LuluTHSu Lulu_Su@wistron.com

SubModel is used to identify network interface.

Signed-off-by: LuluTHSu <Lulu_Su@wistron.com>
@gtmills
Copy link
Contributor

gtmills commented Aug 27, 2021

This is the exact same of the upstream commit:
openbmc/phosphor-dbus-interfaces@ff4702a

Copy link
Contributor

@gtmills gtmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically it is better to cherry-pick the upstream commit so the author gets credit and easier to rebase later. For this, I think it is fine, for next time.

@LuluTHSu
Copy link
Author

Typically it is better to cherry-pick the upstream commit so the author gets credit and easier to rebase later. For this, I think it is fine, for next time.

I will use "cherry-pick" in the future, thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants