Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: js-scope refactor - various renames #195

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

francinelucca
Copy link
Contributor

@francinelucca francinelucca commented Feb 28, 2024

Closes #193

Implements refactors needed for JS scope as per JS Scope low level design mural.

Changelog

New

  • js folder under scopes that will hold logic for incoming JS scope functionality.

Changed

  • Moved some JsxScope functions into their own function files and located under new "js" scope folder. See JS Scope low level design mural "refactor" section for more details.
  • Generalized some functions, interfaces, classes and types so that they can be consumed by both js and jsx scope. See JS Scope low level design mural "refactor" section for more details.

Testing / reviewing

Functionality remains exactly the same, all unit tests should continue to pass and code coverage should be on par with main.

@francinelucca francinelucca changed the title fix: js-scope refactor - various renames WIP - fix: js-scope refactor - various renames Feb 28, 2024
@francinelucca francinelucca marked this pull request as ready for review March 4, 2024 22:31
@francinelucca francinelucca requested a review from a team as a code owner March 4, 2024 22:31
@francinelucca francinelucca changed the title WIP - fix: js-scope refactor - various renames fix: js-scope refactor - various renames Mar 8, 2024
Copy link
Contributor

@jharvey10 jharvey10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in online code review! 🚀

Copy link

sonarcloud bot commented Mar 11, 2024

@francinelucca francinelucca merged commit dc4da39 into main Mar 11, 2024
6 checks passed
@francinelucca francinelucca deleted the 193-js-scope---coding---refactor branch March 11, 2024 20:11
@telemmy telemmy bot mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS Scope - Coding - Refactor
2 participants