Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 8253952 #554

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Backport 8253952 #554

merged 1 commit into from
Jul 21, 2022

Conversation

r30shah
Copy link
Contributor

@r30shah r30shah commented Jul 21, 2022

This PR backports changes from 8253952 which refines ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size.

Issue eclipse-openj9/openj9#14948

Signed-off-by: Rahil Shah rahil@ca.ibm.com

@pshipton
Copy link
Member

jenkins compile amac jdk11

}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add a newline here to match the original change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pshipton
Copy link
Member

pshipton commented Jul 21, 2022

Ran java/util/zip/CopyZipFile.java in a grinder, which passed
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1170

Running all sanity.openjdk as well, which passed
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1169

…e ZipEntry's compressed size

Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
@pshipton pshipton merged commit f96abef into ibmruntimes:openj9 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants